gsrlabs/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2026-01-29 07:02:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

runtime: skip mayMoreStackMove in goroutine leak tests

Browse Source 
mayMoreStackMove may introduce more scheduler chaos because of all the
stack movement (not as much as mayMoreStackPreempt) so let's disable the
tests here too, since we have evidence that they can produce false
negatives under this configuration. Though we're not 100% sure why this
is happening yet, let's at least stop the flow of flaky failures.

For #75729.

Change-Id: I16d13dba9a61fbd47563b21cbf188e4754f58213
Reviewed-on: https://go-review.googlesource.com/c/go/+/726526
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
Michael Anthony Knyszek
2025-12-03 22:52:45 +00:00
committed by Michael Knyszek
parent 44cb82449e
commit 8947f092a8
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/runtime/goroutineleakprofile_test.go
View File

@@ -14,10 +14,13 @@ import (
)
func TestGoroutineLeakProfile(t *testing.T) {
if strings.Contains(os.Getenv("GOFLAGS"), "mayMoreStackPreempt") {
// Some tests have false negatives under mayMoreStackPreempt. This may be a test-only issue,
// but needs more investigation.
testenv.SkipFlaky(t, 75729)
// Some tests have false negatives under mayMoreStackPreempt and mayMoreStackMove.
// This may be a test-only issue in that they're just sensitive to scheduling, but it
// needs more investigation.
for _, cfg := range []string{"mayMoreStackPreempt", "mayMoreStackMove"} {
if strings.Contains(os.Getenv("GOFLAGS"), cfg) {
testenv.SkipFlaky(t, 75729)
}
}
// Goroutine leak test case.