From 1edeebeea09c66c5a886ccfefb1be5dafac5c893 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Thu, 25 Sep 2025 11:02:34 -0700 Subject: [PATCH] unix: mkall.sh: fail if docker build failed When docker build fails, docker run (in my case podman) tries to find the generate:linux image from various mirrors, which is very confusing. We should error out if docker build fails. Change-Id: I4fd78e9fa339e03029b1bf003b3239ca23a7ed1b Reviewed-on: https://go-review.googlesource.com/c/sys/+/706916 LUCI-TryBot-Result: Go LUCI Auto-Submit: Kirill Kolyshkin Reviewed-by: Junyang Shao Reviewed-by: Sean Liao Reviewed-by: Carlos Amedee --- unix/mkall.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/unix/mkall.sh b/unix/mkall.sh index e6f31d37..d0ed6119 100755 --- a/unix/mkall.sh +++ b/unix/mkall.sh @@ -49,6 +49,7 @@ esac if [[ "$GOOS" = "linux" ]]; then # Use the Docker-based build system # Files generated through docker (use $cmd so you can Ctl-C the build or run) + set -e $cmd docker build --tag generate:$GOOS $GOOS $cmd docker run --interactive --tty --volume $(cd -- "$(dirname -- "$0")/.." && pwd):/build generate:$GOOS exit