From 52ba35ddf9b65dc3ad27218743aa2444fe13b690 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Fri, 12 Jan 2018 16:25:57 +0100 Subject: [PATCH] unix: check error return of os.Symlink in tests on Linux Change-Id: Iddb6fbcb0f0f834fa9fd7ef95d57aa8c7b4007fd Reviewed-on: https://go-review.googlesource.com/87575 Run-TryBot: Tobias Klauser Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- unix/syscall_linux_test.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/unix/syscall_linux_test.go b/unix/syscall_linux_test.go index 31ae24c3..9cc07549 100644 --- a/unix/syscall_linux_test.go +++ b/unix/syscall_linux_test.go @@ -20,9 +20,12 @@ func TestFchmodat(t *testing.T) { defer chtmpdir(t)() touch(t, "file1") - os.Symlink("file1", "symlink1") + err := os.Symlink("file1", "symlink1") + if err != nil { + t.Fatal(err) + } - err := unix.Fchmodat(unix.AT_FDCWD, "symlink1", 0444, 0) + err = unix.Fchmodat(unix.AT_FDCWD, "symlink1", 0444, 0) if err != nil { t.Fatalf("Fchmodat: unexpected error: %v", err) } @@ -239,7 +242,10 @@ func TestFstatat(t *testing.T) { t.Errorf("Fstatat: returned stat does not match Stat") } - os.Symlink("file1", "symlink1") + err = os.Symlink("file1", "symlink1") + if err != nil { + t.Fatal(err) + } err = unix.Lstat("symlink1", &st1) if err != nil {