From a200a19cb90b19de298170992778b1fda7217bd6 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Mon, 25 Jun 2018 08:32:13 +0200 Subject: [PATCH] unix: don't check atime in TestUtimesNanoAt If the underlying filesystem doesn't support atime or was mounted with the noatime mount option, TestUtimesNanoAt fails when comparing atime: --- FAIL: TestUtimesNanoAt (0.00s) syscall_linux_test.go:144: UtimesNanoAt: wrong atime: {1111 0} syscall_linux_test.go:147: UtimesNanoAt: wrong mtime: {3333 0} FAIL FAIL golang.org/x/sys/unix 0.376s Fix it by dropping the atime comparison, it's enough to verify UtimesNanoAt working correctly by comparing mtime. Fixes golang/go#26034 Change-Id: Id868f9d4c6a856a99ae930a46bfe91bd64ca8570 Reviewed-on: https://go-review.googlesource.com/120562 Run-TryBot: Tobias Klauser TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- unix/syscall_linux_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/unix/syscall_linux_test.go b/unix/syscall_linux_test.go index 1cc89146..4a25ba85 100644 --- a/unix/syscall_linux_test.go +++ b/unix/syscall_linux_test.go @@ -140,9 +140,8 @@ func TestUtimesNanoAt(t *testing.T) { if err != nil { t.Fatalf("Lstat: %v", err) } - if st.Atim != ts[0] { - t.Errorf("UtimesNanoAt: wrong atime: %v", st.Atim) - } + + // Only check Mtim, Atim might not be supported by the underlying filesystem if st.Mtim != ts[1] { t.Errorf("UtimesNanoAt: wrong mtime: %v", st.Mtim) }