From c11f84a56e43e20a78cee75a7c034031ecf57d1f Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Fri, 25 May 2018 15:55:20 +0200 Subject: [PATCH] unix: don't check atime in TestStatx On some builders TestStatx occassionally fails when comparing atime between Statx and Stat/Lstat. --- FAIL: TestStatx (0.00s) syscall_linux_test.go:365: Statx: returned stat atime does not match Lstat Fix it by dropping the atime comparison, it's enough to verify Statx working correctly by comparing ctime and mtime. Also, not all filesystems support atime. Change-Id: I7da68bd20b9b21274c4993aa2c4241395d2c933a Reviewed-on: https://go-review.googlesource.com/114616 Run-TryBot: Tobias Klauser TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- unix/syscall_linux_test.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/unix/syscall_linux_test.go b/unix/syscall_linux_test.go index 842be627..7fd5e2a9 100644 --- a/unix/syscall_linux_test.go +++ b/unix/syscall_linux_test.go @@ -317,13 +317,9 @@ func TestStatx(t *testing.T) { t.Errorf("Statx: returned stat mode does not match Stat") } - atime := unix.StatxTimestamp{Sec: int64(st.Atim.Sec), Nsec: uint32(st.Atim.Nsec)} ctime := unix.StatxTimestamp{Sec: int64(st.Ctim.Sec), Nsec: uint32(st.Ctim.Nsec)} mtime := unix.StatxTimestamp{Sec: int64(st.Mtim.Sec), Nsec: uint32(st.Mtim.Nsec)} - if stx.Atime != atime { - t.Errorf("Statx: returned stat atime does not match Stat") - } if stx.Ctime != ctime { t.Errorf("Statx: returned stat ctime does not match Stat") } @@ -364,13 +360,9 @@ func TestStatx(t *testing.T) { t.Errorf("Statx: returned stat mode does not match Lstat") } - atime = unix.StatxTimestamp{Sec: int64(st.Atim.Sec), Nsec: uint32(st.Atim.Nsec)} ctime = unix.StatxTimestamp{Sec: int64(st.Ctim.Sec), Nsec: uint32(st.Ctim.Nsec)} mtime = unix.StatxTimestamp{Sec: int64(st.Mtim.Sec), Nsec: uint32(st.Mtim.Nsec)} - if stx.Atime != atime { - t.Errorf("Statx: returned stat atime does not match Lstat") - } if stx.Ctime != ctime { t.Errorf("Statx: returned stat ctime does not match Lstat") }