Sebastiaan van Stijn
d684c6f886
execabs: isGo119ErrDot: use errors.Is instead of string-matching
...
Addresses the TODO added in CL 403256.
Change-Id: Iae44242e00b6a309cc0f1e336462bc2d4995a5e2
GitHub-Last-Rev: 1adfdb7994golang/sys#142
Reviewed-on: https://go-review.googlesource.com/c/sys/+/448877
Auto-Submit: Ian Lance Taylor <iant@google.com >
Run-TryBot: Ian Lance Taylor <iant@google.com >
Reviewed-by: Michael Knyszek <mknyszek@google.com >
Run-TryBot: Ian Lance Taylor <iant@golang.org >
TryBot-Result: Gopher Robot <gobot@golang.org >
Reviewed-by: Ian Lance Taylor <iant@google.com >
2022-11-10 21:11:17 +00:00
Bryan C. Mills
988cb79eb6
execabs: add legacy "//+build" constraints
...
Go releases before Go 1.17 are no longer supported, and Go 1.17
supports the newer "//go:build" syntax, so the older "//+build"
variation is no longer required by Go's support policy. However, the
x/sys module is very low-level and empirically some users are still on
unsupported Go releases, so there is little harm in adding the older
variations.
Fixes golang/go#52668 .
Change-Id: Ieb8e64e450b9d795f2753fc5f99b36816a3dbff3
Reviewed-on: https://go-review.googlesource.com/c/sys/+/403695
Run-TryBot: Bryan Mills <bcmills@google.com >
Reviewed-by: Russ Cox <rsc@golang.org >
2022-05-03 16:30:25 +00:00
Russ Cox
b6088ccd6c
execabs: make safe for Go 1.19
...
To preserve the same errors that LookPath used to return,
LookPath needs to know to ignore the new Go 1.19 exec.ErrDot errors.
For golang/go#43724 .
Change-Id: I8938813a1a4e14bf697f05879e3ab212611644da
Reviewed-on: https://go-review.googlesource.com/c/sys/+/403256
Run-TryBot: Russ Cox <rsc@golang.org >
Reviewed-by: Ian Lance Taylor <iant@google.com >
TryBot-Result: Gopher Robot <gobot@golang.org >
2022-05-02 12:42:56 +00:00
Tobias Klauser
9b0068b266
execabs: disable tests on ios and js/wasm
...
TestCommand and TestLookPath fail on the js/wasm builder and likely
fail on ios as well.
Like the tests in internal/execabs, skip them for these platforms.
This fixes the js/wasm builder after CL 284753.
For golang/go#11811
Change-Id: I1038128bd4c7bd410ac1357dedda5e3eef5c7bbb
Reviewed-on: https://go-review.googlesource.com/c/sys/+/285712
Trust: Tobias Klauser <tobias.klauser@gmail.com >
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com >
TryBot-Result: Go Bot <gobot@golang.org >
Reviewed-by: Ian Lance Taylor <iant@golang.org >
2021-01-23 11:12:55 +00:00
Roland Shoemaker
b64e53b001
execabs: create execabs package
...
This package provides an alternative to os/exec that guarantees
never to satisfy a PATH lookup using an executable in the current
directory.
Change-Id: Id978f8039fe21687059c788836c79ae8e0930e92
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/949732
Reviewed-by: Katie Hockman <katiehockman@google.com >
Reviewed-by: Russ Cox <rsc@google.com >
Reviewed-on: https://go-review.googlesource.com/c/sys/+/284753
Trust: Roland Shoemaker <roland@golang.org >
Run-TryBot: Roland Shoemaker <roland@golang.org >
Reviewed-by: Russ Cox <rsc@golang.org >
Reviewed-by: Katie Hockman <katie@golang.org >
TryBot-Result: Go Bot <gobot@golang.org >
2021-01-19 21:28:57 +00:00
