Jason A. Donenfeld
c46e0d965b
windows/registry: do not generate unaligned loads
...
Byte slices aren't necessarily aligned, which means casting them to
integer types and dereferencing may result in an unaligned load. This
is mostly fine on Intel but isn't necessarily fine on other platforms.
Any good compiler will generate optimal code for the platform using the
pattern of this commit.
Change-Id: I6dd8debad1cb850b8562ee96ae0f366d1f822a6f
Reviewed-on: https://go-review.googlesource.com/c/sys/+/176857
Run-TryBot: Jason Donenfeld <Jason@zx2c4.com >
TryBot-Result: Gobot Gobot <gobot@golang.org >
Reviewed-by: Ian Lance Taylor <iant@golang.org >
2019-05-22 03:42:48 +00:00
Tobias Klauser
a5b02f93d8
windows: add "generate" build tag
...
cmd/go supports the "generate" build tag as of CL 175983. Add it to the
files which are just used for generating errors and syscall wrappers.
Also see golang/go#31920
Change-Id: Ib26c90af0ac1fb7bae81366a46dedf028b787566
Reviewed-on: https://go-review.googlesource.com/c/sys/+/175899
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com >
TryBot-Result: Gobot Gobot <gobot@golang.org >
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
2019-05-09 14:14:14 +00:00
Tobias Klauser
8014b7b116
windows: follow convention for generated code comment
...
Regenerated with go tip to get the generated code comment following the
convention (https://golang.org/s/generatedcode ).
Change-Id: Ie1365ecfa532b940bf7cfc8579c4cbda71cf7f76
Reviewed-on: https://go-review.googlesource.com/118817
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com >
TryBot-Result: Gobot Gobot <gobot@golang.org >
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
Reviewed-by: Alex Brainman <alex.brainman@gmail.com >
2018-06-15 09:36:15 +00:00
Shamil Garatuev
f6cff0780e
windows/registry: improve ReadSubKeyNames permissions
...
The existing implementation requires QUERY_VALUE and ENUMERATE_SUB_KEYS permissions to enumerate
subkeys, so, using registry key name limits, Stat function could be excluded
from methods body and improved method requires only ENUMERATE_SUB_KEYS permission
Registry elements size limits described there:
https://msdn.microsoft.com/library/windows/desktop/ms724872.aspx
Fixes golang/go#23869
Change-Id: Id96beb9b0b294f01cc6eb1bb53bee5f50d02ea7e
Reviewed-on: https://go-review.googlesource.com/95655
Reviewed-by: Alex Brainman <alex.brainman@gmail.com >
Run-TryBot: Alex Brainman <alex.brainman@gmail.com >
TryBot-Result: Gobot Gobot <gobot@golang.org >
2018-02-24 23:21:35 +00:00
Francesc Campoy
6faef541c7
golang.org/x/sys: fix typo in test
...
Change-Id: I5709137db7308934e627d866da1cc8aa5abca7db
Reviewed-on: https://go-review.googlesource.com/47310
Reviewed-by: Rob Pike <r@golang.org >
2017-07-05 19:55:40 +00:00
Alex Brainman
f5a6bd4305
windows/registry: add code to access remote pc registry
...
Introduce OpenRemoteKey function that opens some
root registry keys on remote computer.
Also add PERFORMANCE_DATA key, since it is one of
root keys accessible via OpenRemoteKey.
Change-Id: I738fdfee52a34acd4dc09ddb91fcf0e4c707bd83
Reviewed-on: https://go-review.googlesource.com/33814
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org >
TryBot-Result: Gobot Gobot <gobot@golang.org >
2016-12-04 22:43:27 +00:00
Alex Brainman
ca83bd2cb9
windows: run "go generate"
...
Change-Id: Ide01e409af85a5e2615ba647b44eda67bc14c07f
Reviewed-on: https://go-review.googlesource.com/33812
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org >
TryBot-Result: Gobot Gobot <gobot@golang.org >
2016-12-02 08:03:26 +00:00
Alex Brainman
a646d33e2e
windows: make "go generate" command work on any OS
...
See issue golang/go#16368 for details.
Updates golang/go#16368
Change-Id: Ic3294385a350aee41887f59cbcf5b0af7742ff3b
Reviewed-on: https://go-review.googlesource.com/24952
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
2016-07-17 07:19:31 +00:00
Alex Brainman
e82cb4d7df
windows: remove non-existing now mksyscall_windows.go -xsys flag
...
Updates golang/go#15167
Change-Id: I58bd7e4e6ba88a2ffba11506e5ac0495de303b5b
Reviewed-on: https://go-review.googlesource.com/23023
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
Run-TryBot: Alex Brainman <alex.brainman@gmail.com >
2016-05-12 03:25:10 +00:00
Alex Brainman
042a8f53ce
windows: add NewLazySystemDLL and use it in zsyscall_windows.go
...
If we want new secure DLL approach to be adopted, we should make
conversion as simple as possible to explain and implement.
I think that replacing
syscall.NewLazyDLL(...) -> windows.NewLazySystemDLL(...)
is easier than
syscall.NewLazyDLL(...) -> &windows.LazyDLL{Name: ..., System: true}
So I propose we introduce convenience function NewLazySystemDLL.
$GOROOT/src/mksyscall_windows.go changes in the following CL.
Change-Id: If3432aff301c347cb355e4e837834696191b2219
Reviewed-on: https://go-review.googlesource.com/21592
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
2016-04-06 06:33:47 +00:00
Brad Fitzpatrick
3dff6e19a5
windows: add LoadLibraryEx, add LazyDLL.System
...
Updates golang/go#14959
Change-Id: Ib91c359c3df919df0b30e584d38e56f79f3e3dc9
Reviewed-on: https://go-review.googlesource.com/21388
Reviewed-by: Russ Cox <rsc@golang.org >
Reviewed-by: Alex Brainman <alex.brainman@gmail.com >
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org >
2016-04-02 00:33:28 +00:00
Alex Brainman
442cd60086
windows: copy latest changes from internal/syscall/windows
...
Copy of CL 4310, 6140, 17412, 17997 and 17998.
Change-Id: I7db8722a1c37f033d5ce6644859ef15c58289a46
Reviewed-on: https://go-review.googlesource.com/18552
Reviewed-by: Rob Pike <r@golang.org >
2016-01-13 01:14:10 +00:00
Alex Brainman
16e60ce682
windows/registry: do not panic when data is large
...
Allow registry blobs to be as large as 500MB
Copy of CL 14287.
Fixes golang/go#12493
Change-Id: I37b82fcf90ff2acef83c66016375fcae15e6eefc
Reviewed-on: https://go-review.googlesource.com/14288
Reviewed-by: Ian Lance Taylor <iant@golang.org >
2015-09-09 02:29:49 +00:00
Daniel Johansson
98fc11432b
windows/registry: copy latest changes from internal/syscall/registry
...
This CL includes changes from:
https://golang.org/cl/13929
https://golang.org/cl/13854
Part of fixing https://golang.org/issue/12015
Change-Id: I62e00e165d97d2349c89a783aed7fcbe9e0abd34
Reviewed-on: https://go-review.googlesource.com/14016
Run-TryBot: Alex Brainman <alex.brainman@gmail.com >
Reviewed-by: Alex Brainman <alex.brainman@gmail.com >
2015-08-30 10:08:33 +00:00
Alex Brainman
0879c8a4d6
windows/registry: remove debugging dreg
...
copy of CL 13828 change
Change-Id: I48ea36171281eed8e59b92e130c762142fb94604
Reviewed-on: https://go-review.googlesource.com/13829
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org >
2015-08-24 23:40:35 +00:00
Alex Brainman
87f732a730
windows/registry: copy latest changes from internal/syscall/registry
...
This CL includes changes from:
http://golang.org/cl/9805
http://golang.org/cl/9806
http://golang.org/cl/9901
Change-Id: I1f41a8215f9f760c0d3b84596e37bf48bf4c9bc2
Reviewed-on: https://go-review.googlesource.com/10132
Reviewed-by: Rob Pike <r@golang.org >
2015-05-15 05:08:24 +00:00
Alex Brainman
bbc47fbbc8
windows/registry: mark string end with 0 before calling Windows ExpandEnvironmentStrings
...
Change-Id: I02bfcdeac44167d1dbeb15bcd5c82111fba3f527
Reviewed-on: https://go-review.googlesource.com/9234
Reviewed-by: Rob Pike <r@golang.org >
2015-04-23 02:52:27 +00:00
Alex Brainman
e961698092
windows/registry: add new package to manipulate Windows registry
...
Change-Id: Ia7c3d6250c041b95aa43ca5ca2a92251c480ef77
Reviewed-on: https://go-review.googlesource.com/8843
Reviewed-by: Rob Pike <r@golang.org >
2015-04-15 07:18:44 +00:00