Jason A. Donenfeld 04d7465088 windows: correct signature of recently added GetWindowThreadProcessId ...

This function returns 0 and sets last error on failure. While this isn't
said explicitly on MSDN, there's no PID 0, and trivial reverse
engineering shows that this is the case. For example:

.text:00000001800035ED loc_1800035ED:                          ; CODE XREF: GetWindowThreadProcessId+23↑j
.text:00000001800035ED                                         ; GetWindowThreadProcessId+3D↑j ...
.text:00000001800035ED                 mov     ecx, 578h       ; LastError
.text:00000001800035F2                 call    cs:__imp_RtlSetLastWin32Error
.text:00000001800035F9                 nop     dword ptr [rax+rax+00h]
.text:00000001800035FE
.text:00000001800035FE loc_1800035FE:                          ; CODE XREF: GetWindowThreadProcessId+65↑j
.text:00000001800035FE                 xor     eax, eax
.text:0000000180003600                 jmp     short loc_1800035AA

This function was also just added by a user who is likely its only
consumer, so this error is not too late to fix.

Change-Id: I5dd24e78c006686bb8f1288ad0fe63cd67df56a6
Reviewed-on: https://go-review.googlesource.com/c/sys/+/285272
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

2021-01-22 09:31:01 +00:00

..

mkwinsyscall

windows/mkwinsyscall: account for non-"err" return values when processing "?"

2020-12-04 22:54:03 +00:00

registry

windows/mkwinsyscall: use global variable to avoid allocation in errnoErr

2020-10-24 23:29:16 +00:00

svc

windows: remove ErrorControl value check in CreateService

2020-12-11 09:08:39 +00:00

aliases.go

unix, windows: add type aliases to std syscall for Signal, Errno, SysProcAttr

2018-08-02 20:32:16 +00:00

dll_windows.go

windows: add DLL directory search path manipulation functions

2020-11-26 23:39:18 +00:00

empty.s

windows: add empty.s to fix build with Go 1.11 and earlier

2019-11-10 16:31:57 +00:00

env_windows.go

windows: fix -d=checkptr slice failures

2020-05-19 10:57:57 +00:00

eventlog.go

windows/svc: add new package to help create and manage Windows services

2015-05-01 05:26:56 +00:00

exec_windows.go

windows: fix race when allocating buffer for some windows syscalls

2015-04-09 00:47:30 +00:00

memory_windows.go

windows: add missing page flag constants

2020-11-07 08:05:50 +00:00

mkerrors.bash

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

mkknownfolderids.bash

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

mksyscall.go

windows/mkwinsyscall: import mksyscall_windows.go from go repo

2019-10-03 21:23:58 +00:00

race0.go

all: single space after period

2017-10-25 20:39:07 +00:00

race.go

all: single space after period

2017-10-25 20:39:07 +00:00

security_windows.go

windows: add Token.IsRestricted helper

2020-11-26 22:47:55 +00:00

service.go

windows: add SubscribeServiceChangeNotifications for service tracking

2020-12-04 22:54:10 +00:00

setupapierrors_windows.go

windows: add missing error constants from setupapi.h

2020-11-12 07:39:58 +00:00

str.go

go.sys: fix imports to cgc/p/go.sys, add build tags

2014-08-12 22:59:00 -07:00

syscall_test.go

windows: add (*DLL).FindProcByOrdinal

2020-05-09 04:47:56 +00:00

syscall_windows_test.go

windows: add IsWow64Process2 for detecting x86 on arm

2020-11-13 23:30:24 +00:00

syscall_windows.go

windows: correct signature of recently added GetWindowThreadProcessId

2021-01-22 09:31:01 +00:00

syscall.go

unix,windows,plan9: add Byte{Slice,Ptr}ToString functions

2020-10-20 23:07:47 +00:00

types_windows_386.go

windows: use GOARCH-specific JOBOBJECT_BASIC_LIMIT_INFORMATION

2020-09-05 00:46:41 +00:00

types_windows_amd64.go

windows: use GOARCH-specific JOBOBJECT_BASIC_LIMIT_INFORMATION

2020-09-05 00:46:41 +00:00

types_windows_arm.go

windows: use GOARCH-specific JOBOBJECT_BASIC_LIMIT_INFORMATION

2020-09-05 00:46:41 +00:00

types_windows.go

windows: add PFXImportCertStore and CertDuplicateCertificateContext

2020-12-31 18:44:35 +00:00

zerrors_windows.go

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

zknownfolderids_windows.go

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

zsyscall_windows.go

windows: correct signature of recently added GetWindowThreadProcessId

2021-01-22 09:31:01 +00:00