mirror of
https://github.com/golang/sys.git
synced 2026-02-08 11:46:04 +03:00
fe76b779f2
This CL fixes unsafe casts to slices that are missing length or capacity.
Running tests with -d=checkptr enabled may panic on casting unsafe.Pointer to a static array of large predefined length, that is most likely much bigger than the size of the actual array in memory. Checkptr check is not satisfied if slicing operator misses length and capacity arguments `(*[(1 << 30) - 1]uint16)(unsafe.Pointer(p))[:]`, or when there is no slicing at all `(*[(1 << 30) - 1]uint16)(unsafe.Pointer(p))`.
To find all potential cases I used `grep -nr ")(unsafe.Pointer(" ./windows`, then filtered out safe casts when object size is always static and known at compile time.
To reproduce the issue run tests with checkptr enabled `go test -a -gcflags=all=-d=checkptr ./windows/...`.
Updates golang/go#34972
Fixes golang/go#38355
Change-Id: I9dd2084b4f9fb7618cdb140fb2f38b56b6d6cc04
GitHub-Last-Rev: 73288ad18a
GitHub-Pull-Request: golang/sys#65
Reviewed-on: https://go-review.googlesource.com/c/sys/+/225418
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
55 lines
1.2 KiB
Go
55 lines
1.2 KiB
Go
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Windows environment variables.
|
|
|
|
package windows
|
|
|
|
import (
|
|
"syscall"
|
|
"unsafe"
|
|
)
|
|
|
|
func Getenv(key string) (value string, found bool) {
|
|
return syscall.Getenv(key)
|
|
}
|
|
|
|
func Setenv(key, value string) error {
|
|
return syscall.Setenv(key, value)
|
|
}
|
|
|
|
func Clearenv() {
|
|
syscall.Clearenv()
|
|
}
|
|
|
|
func Environ() []string {
|
|
return syscall.Environ()
|
|
}
|
|
|
|
// Returns a default environment associated with the token, rather than the current
|
|
// process. If inheritExisting is true, then this environment also inherits the
|
|
// environment of the current process.
|
|
func (token Token) Environ(inheritExisting bool) (env []string, err error) {
|
|
var block *uint16
|
|
err = CreateEnvironmentBlock(&block, token, inheritExisting)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer DestroyEnvironmentBlock(block)
|
|
blockp := uintptr(unsafe.Pointer(block))
|
|
for {
|
|
entry := UTF16PtrToString((*uint16)(unsafe.Pointer(blockp)))
|
|
if len(entry) == 0 {
|
|
break
|
|
}
|
|
env = append(env, entry)
|
|
blockp += 2 * (uintptr(len(entry)) + 1)
|
|
}
|
|
return env, nil
|
|
}
|
|
|
|
func Unsetenv(key string) error {
|
|
return syscall.Unsetenv(key)
|
|
}
|