Jason A. Donenfeld 0b153f535c windows: fix ShellExecute return condition ...

ShellExecute is an ancient API with an unusual return signature. It
pretends to return an HINSTANCE for backwards compatibility with Windows
3, but it's actualy a fake HINSTANCE. What's really happening here,
according to MSDN, is that it returns either an Windows error less
than or equal to 32, or it succeeds. So we adjust the return value
accordingly.

Prior to this commit, it was impossible to tell whether this command had
succeeded. For example, when using the "runas" verb, ShellExecute did
not correctly indicate whether or not permission was granted.

Change-Id: Ie60554d6465798bacb9a225c4ead7e8dd62bce14
Reviewed-on: https://go-review.googlesource.com/c/sys/+/199521
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nenad Kozul <knenad@gmail.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

2019-10-08 10:27:50 +00:00

..

mkwinsyscall

windows/mkwinsyscall: import mksyscall_windows.go from go repo

2019-10-03 21:23:58 +00:00

registry

windows/mkwinsyscall: import mksyscall_windows.go from go repo

2019-10-03 21:23:58 +00:00

svc

windows/svc: use CloseServiceHandle for service handles

2019-10-02 09:15:54 +00:00

aliases.go

unix, windows: add type aliases to std syscall for Signal, Errno, SysProcAttr

2018-08-02 20:32:16 +00:00

dll_windows.go

windows: use go:linkname instead of assembly

2019-10-07 15:44:56 +00:00

env_windows.go

windows: add token environment functions

2019-05-15 12:05:40 +00:00

eventlog.go

windows/svc: add new package to help create and manage Windows services

2015-05-01 05:26:56 +00:00

exec_windows.go

windows: fix race when allocating buffer for some windows syscalls

2015-04-09 00:47:30 +00:00

memory_windows.go

all: single space after period

2017-10-25 20:39:07 +00:00

mkerrors.bash

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

mkknownfolderids.bash

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

mksyscall.go

windows/mkwinsyscall: import mksyscall_windows.go from go repo

2019-10-03 21:23:58 +00:00

race0.go

all: single space after period

2017-10-25 20:39:07 +00:00

race.go

all: single space after period

2017-10-25 20:39:07 +00:00

security_windows.go

windows: revert breaking API changes from CL 196798, add new accessor funcs

2019-09-26 18:03:25 +00:00

service.go

windows: add support for automatic delayed start in windows service

2019-08-04 05:38:45 +00:00

str.go

go.sys: fix imports to cgc/p/go.sys, add build tags

2014-08-12 22:59:00 -07:00

syscall_test.go

windows: add Windows directory accessors

2019-08-26 19:00:57 +00:00

syscall_windows_test.go

windows: revert breaking API changes from CL 196798, add new accessor funcs

2019-09-26 18:03:25 +00:00

syscall_windows.go

windows: fix ShellExecute return condition

2019-10-08 10:27:50 +00:00

syscall.go

plan9, unix, windows: add paragraph breaks in docs

2018-03-18 19:08:47 +00:00

types_windows_386.go

all: single space after period

2017-10-25 20:39:07 +00:00

types_windows_amd64.go

all: single space after period

2017-10-25 20:39:07 +00:00

types_windows_arm.go

windows: add support for windows/arm

2018-09-24 17:59:46 +00:00

types_windows.go

windows: add module handle functions

2019-10-07 09:26:33 +00:00

zerrors_windows.go

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

zknownfolderids_windows.go

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

zsyscall_windows.go

windows: fix ShellExecute return condition

2019-10-08 10:27:50 +00:00