mirror of
https://github.com/golang/sys.git
synced 2026-02-07 11:25:08 +03:00
This package provides an alternative to os/exec that guarantees never to satisfy a PATH lookup using an executable in the current directory. Change-Id: Id978f8039fe21687059c788836c79ae8e0930e92 Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/949732 Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-by: Russ Cox <rsc@google.com> Reviewed-on: https://go-review.googlesource.com/c/sys/+/284753 Trust: Roland Shoemaker <roland@golang.org> Run-TryBot: Roland Shoemaker <roland@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Katie Hockman <katie@golang.org> TryBot-Result: Go Bot <gobot@golang.org>
108 lines
3.4 KiB
Go
108 lines
3.4 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package execabs
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
func TestFixCmd(t *testing.T) {
|
|
cmd := &exec.Cmd{Path: "hello"}
|
|
fixCmd("hello", cmd)
|
|
if cmd.Path != "" {
|
|
t.Errorf("fixCmd didn't clear cmd.Path")
|
|
}
|
|
expectedErr := fmt.Sprintf("hello resolves to executable in current directory (.%chello)", filepath.Separator)
|
|
if err := cmd.Run(); err == nil {
|
|
t.Fatal("Command.Run didn't fail")
|
|
} else if err.Error() != expectedErr {
|
|
t.Fatalf("Command.Run returned unexpected error: want %q, got %q", expectedErr, err.Error())
|
|
}
|
|
}
|
|
|
|
func TestCommand(t *testing.T) {
|
|
for _, cmd := range []func(string) *Cmd{
|
|
func(s string) *Cmd { return Command(s) },
|
|
func(s string) *Cmd { return CommandContext(context.Background(), s) },
|
|
} {
|
|
tmpDir, err := ioutil.TempDir("", "execabs-test")
|
|
if err != nil {
|
|
t.Fatalf("ioutil.TempDir failed: %s", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
executable := "execabs-test"
|
|
if runtime.GOOS == "windows" {
|
|
executable += ".exe"
|
|
}
|
|
if err = ioutil.WriteFile(filepath.Join(tmpDir, executable), []byte{1, 2, 3}, 0111); err != nil {
|
|
t.Fatalf("ioutil.WriteFile failed: %s", err)
|
|
}
|
|
cwd, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatalf("os.Getwd failed: %s", err)
|
|
}
|
|
defer os.Chdir(cwd)
|
|
if err = os.Chdir(tmpDir); err != nil {
|
|
t.Fatalf("os.Chdir failed: %s", err)
|
|
}
|
|
if runtime.GOOS != "windows" {
|
|
// add "." to PATH so that exec.LookPath looks in the current directory on
|
|
// non-windows platforms as well
|
|
origPath := os.Getenv("PATH")
|
|
defer os.Setenv("PATH", origPath)
|
|
os.Setenv("PATH", fmt.Sprintf(".:%s", origPath))
|
|
}
|
|
expectedErr := fmt.Sprintf("execabs-test resolves to executable in current directory (.%c%s)", filepath.Separator, executable)
|
|
if err = cmd("execabs-test").Run(); err == nil {
|
|
t.Fatalf("Command.Run didn't fail when exec.LookPath returned a relative path")
|
|
} else if err.Error() != expectedErr {
|
|
t.Errorf("Command.Run returned unexpected error: want %q, got %q", expectedErr, err.Error())
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestLookPath(t *testing.T) {
|
|
tmpDir, err := ioutil.TempDir("", "execabs-test")
|
|
if err != nil {
|
|
t.Fatalf("ioutil.TempDir failed: %s", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
executable := "execabs-test"
|
|
if runtime.GOOS == "windows" {
|
|
executable += ".exe"
|
|
}
|
|
if err = ioutil.WriteFile(filepath.Join(tmpDir, executable), []byte{1, 2, 3}, 0111); err != nil {
|
|
t.Fatalf("ioutil.WriteFile failed: %s", err)
|
|
}
|
|
cwd, err := os.Getwd()
|
|
if err != nil {
|
|
t.Fatalf("os.Getwd failed: %s", err)
|
|
}
|
|
defer os.Chdir(cwd)
|
|
if err = os.Chdir(tmpDir); err != nil {
|
|
t.Fatalf("os.Chdir failed: %s", err)
|
|
}
|
|
if runtime.GOOS != "windows" {
|
|
// add "." to PATH so that exec.LookPath looks in the current directory on
|
|
// non-windows platforms as well
|
|
origPath := os.Getenv("PATH")
|
|
defer os.Setenv("PATH", origPath)
|
|
os.Setenv("PATH", fmt.Sprintf(".:%s", origPath))
|
|
}
|
|
expectedErr := fmt.Sprintf("execabs-test resolves to executable in current directory (.%c%s)", filepath.Separator, executable)
|
|
if _, err := LookPath("execabs-test"); err == nil {
|
|
t.Fatalf("LookPath didn't fail when finding a non-relative path")
|
|
} else if err.Error() != expectedErr {
|
|
t.Errorf("LookPath returned unexpected error: want %q, got %q", expectedErr, err.Error())
|
|
}
|
|
}
|