mirror of
https://github.com/golang/sys.git
synced 2026-02-09 12:16:04 +03:00
760e229fe7
Test_anyToSockaddr on linux needs to create a socket with the given domain, type and protocol in order to test anyToSockaddr. Depending on kernel version, permission and other factors, a given combination might not be available on the system that runs the test, as is e.g. the case for AF_CAN/SOCK_DGRAM/CAN_J1939 on several builders after CL 272767. The only reason to create the socket is to be able to get the socket protocol in anyToSockaddr using GetsockoptInt(..., SO_PROTOCOL). Move this implementation into a wrapper func which can be overriden in tests to with a func unconditionally returning the protocol under test. This makes the test less dependent on the system it runs on and should fix the builders broken by CL 272767. While at it also removed the unused SocketSpec type in syscall_internal_bsd_test.go and remove an unnecessary error var declaration. Change-Id: Ie8754cf795fa96980b29ae43777f698cd86ae863 Reviewed-on: https://go-review.googlesource.com/c/sys/+/274046 Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matt Layher <mdlayher@gmail.com>
132 lines
2.7 KiB
Go
132 lines
2.7 KiB
Go
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package unix
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
"unsafe"
|
|
)
|
|
|
|
func Test_anyToSockaddr_darwin(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
rsa *RawSockaddrAny
|
|
sa Sockaddr
|
|
err error
|
|
}{
|
|
{
|
|
name: "AF_SYSTEM emtpy",
|
|
rsa: sockaddrCtlToAny(RawSockaddrCtl{}),
|
|
err: EAFNOSUPPORT,
|
|
},
|
|
{
|
|
name: "AF_SYSTEM no sysaddr",
|
|
rsa: sockaddrCtlToAny(RawSockaddrCtl{
|
|
Sc_family: AF_SYSTEM,
|
|
}),
|
|
err: EAFNOSUPPORT,
|
|
},
|
|
{
|
|
name: "AF_SYSTEM/AF_SYS_CONTROL empty ",
|
|
rsa: sockaddrCtlToAny(RawSockaddrCtl{
|
|
Sc_family: AF_SYSTEM,
|
|
Ss_sysaddr: AF_SYS_CONTROL,
|
|
}),
|
|
sa: &SockaddrCtl{},
|
|
},
|
|
{
|
|
name: "AF_SYSTEM ID and unit",
|
|
rsa: sockaddrCtlToAny(RawSockaddrCtl{
|
|
Sc_family: AF_SYSTEM,
|
|
Ss_sysaddr: AF_SYS_CONTROL,
|
|
Sc_id: 0x42,
|
|
Sc_unit: 0xC71,
|
|
}),
|
|
sa: &SockaddrCtl{
|
|
ID: 0x42,
|
|
Unit: 0xC71,
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
fd := int(0)
|
|
sa, err := anyToSockaddr(fd, tt.rsa)
|
|
if err != tt.err {
|
|
t.Fatalf("unexpected error: %v, want: %v", err, tt.err)
|
|
}
|
|
|
|
if !reflect.DeepEqual(sa, tt.sa) {
|
|
t.Fatalf("unexpected Sockaddr:\n got: %#v\nwant: %#v", sa, tt.sa)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSockaddrCtl_sockaddr(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
sa *SockaddrCtl
|
|
raw *RawSockaddrCtl
|
|
err error
|
|
}{
|
|
{
|
|
name: "empty",
|
|
sa: &SockaddrCtl{},
|
|
raw: &RawSockaddrCtl{
|
|
Sc_len: SizeofSockaddrCtl,
|
|
Sc_family: AF_SYSTEM,
|
|
Ss_sysaddr: AF_SYS_CONTROL,
|
|
},
|
|
},
|
|
{
|
|
name: "with ID and unit",
|
|
sa: &SockaddrCtl{
|
|
ID: 0x42,
|
|
Unit: 0xff,
|
|
},
|
|
raw: &RawSockaddrCtl{
|
|
Sc_len: SizeofSockaddrCtl,
|
|
Sc_family: AF_SYSTEM,
|
|
Ss_sysaddr: AF_SYS_CONTROL,
|
|
Sc_id: 0x42,
|
|
Sc_unit: 0xff,
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
out, l, err := tt.sa.sockaddr()
|
|
if err != tt.err {
|
|
t.Fatalf("unexpected error: %v, want: %v", err, tt.err)
|
|
}
|
|
|
|
// Must be 0 on error or a fixed size otherwise.
|
|
if (tt.err != nil && l != 0) || (tt.raw != nil && l != SizeofSockaddrCtl) {
|
|
t.Fatalf("unexpected Socklen: %d", l)
|
|
}
|
|
|
|
if out != nil {
|
|
raw := (*RawSockaddrCtl)(out)
|
|
if !reflect.DeepEqual(raw, tt.raw) {
|
|
t.Fatalf("unexpected RawSockaddrCtl:\n got: %#v\nwant: %#v", raw, tt.raw)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func sockaddrCtlToAny(in RawSockaddrCtl) *RawSockaddrAny {
|
|
var out RawSockaddrAny
|
|
copy(
|
|
(*(*[SizeofSockaddrAny]byte)(unsafe.Pointer(&out)))[:],
|
|
(*(*[SizeofSockaddrCtl]byte)(unsafe.Pointer(&in)))[:],
|
|
)
|
|
return &out
|
|
}
|