Yaroslav Vorobiov fe76b779f2 windows: fix -d=checkptr slice failures ...

This CL fixes unsafe casts to slices that are missing length or capacity.

Running tests with -d=checkptr enabled may panic on casting unsafe.Pointer to a static array of large predefined length, that is most likely much bigger than the size of the actual array in memory. Checkptr check is not satisfied if slicing operator misses length and capacity arguments `(*[(1 << 30) - 1]uint16)(unsafe.Pointer(p))[:]`, or when there is no slicing at all `(*[(1 << 30) - 1]uint16)(unsafe.Pointer(p))`.

To find all potential cases I used `grep -nr ")(unsafe.Pointer(" ./windows`, then filtered out safe casts when object size is always static and known at compile time.

To reproduce the issue run tests with checkptr enabled `go test -a -gcflags=all=-d=checkptr ./windows/...`.

Updates golang/go#34972
Fixes golang/go#38355

Change-Id: I9dd2084b4f9fb7618cdb140fb2f38b56b6d6cc04
GitHub-Last-Rev: 73288ad18a
GitHub-Pull-Request: golang/sys#65
Reviewed-on: https://go-review.googlesource.com/c/sys/+/225418
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

2020-05-19 10:57:57 +00:00

..

mkwinsyscall

windows/mkwinsyscall: import mksyscall_windows.go from go repo

2019-10-03 21:23:58 +00:00

registry

windows/registry: make '-gcflags=all=-d=checkptr' flag work

2019-10-29 15:55:21 +00:00

svc

windows: fix -d=checkptr slice failures

2020-05-19 10:57:57 +00:00

aliases.go

unix, windows: add type aliases to std syscall for Signal, Errno, SysProcAttr

2018-08-02 20:32:16 +00:00

dll_windows.go

windows: add (*DLL).FindProcByOrdinal

2020-05-09 04:47:56 +00:00

empty.s

windows: add empty.s to fix build with Go 1.11 and earlier

2019-11-10 16:31:57 +00:00

env_windows.go

windows: fix -d=checkptr slice failures

2020-05-19 10:57:57 +00:00

eventlog.go

windows/svc: add new package to help create and manage Windows services

2015-05-01 05:26:56 +00:00

exec_windows.go

windows: fix race when allocating buffer for some windows syscalls

2015-04-09 00:47:30 +00:00

memory_windows.go

all: single space after period

2017-10-25 20:39:07 +00:00

mkerrors.bash

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

mkknownfolderids.bash

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

mksyscall.go

windows/mkwinsyscall: import mksyscall_windows.go from go repo

2019-10-03 21:23:58 +00:00

race0.go

all: single space after period

2017-10-25 20:39:07 +00:00

race.go

all: single space after period

2017-10-25 20:39:07 +00:00

security_windows.go

windows: fix -d=checkptr slice failures

2020-05-19 10:57:57 +00:00

service.go

windows: add support for automatic delayed start in windows service

2019-08-04 05:38:45 +00:00

str.go

go.sys: fix imports to cgc/p/go.sys, add build tags

2014-08-12 22:59:00 -07:00

syscall_test.go

windows: add (*DLL).FindProcByOrdinal

2020-05-09 04:47:56 +00:00

syscall_windows_test.go

windows: add Get*PreferredUILanguages

2019-11-20 13:05:36 +00:00

syscall_windows.go

windows: fix -d=checkptr slice failures

2020-05-19 10:57:57 +00:00

syscall.go

plan9, unix, windows: add paragraph breaks in docs

2018-03-18 19:08:47 +00:00

types_windows_386.go

all: single space after period

2017-10-25 20:39:07 +00:00

types_windows_amd64.go

all: single space after period

2017-10-25 20:39:07 +00:00

types_windows_arm.go

windows: add support for windows/arm

2018-09-24 17:59:46 +00:00

types_windows.go

windows: add missing network-related constants

2020-01-16 00:19:09 +00:00

zerrors_windows.go

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

zknownfolderids_windows.go

windows: allow looking up well-known folder paths

2019-06-13 12:46:09 +00:00

zsyscall_windows.go

windows: fix recvfrom and sendto data types

2019-12-19 23:57:34 +00:00