gsrlabs/sys
1
0
Fork 0
mirror of https://github.com/golang/sys.git synced 2026-02-09 04:06:04 +03:00
Code Issues Packages Projects Releases Wiki Activity

unix: rework TestGetwd to handle test dirs whose names contain symlinks

Browse Source 
TestGetwd can fail on systems that have unexpected directory/partition configurations using symlinks.

Fixes 326678
This commit is contained in:
virtualsue
2018-11-10 10:13:18 +00:00
parent abb8ffd10d
commit 727a6cc6a7
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
unix/syscall_unix_test.go
View File

@@ -453,8 +453,8 @@ func TestGetwd(t *testing.T) {
t.Fatalf("Open .: %s", err)
}
defer fd.Close()
// Don't worry if a few of these directories contain symlinks or don't exist
// on some common unix desktop environments. That will be checked.
// Directory list for test. Do not worry if any are symlinks or do not
// exist on some common unix desktop environments. That will be checked.
dirs := []string{"/", "/usr/bin", "/etc", "/var", "/opt"}
switch runtime.GOOS {
case "android":
@@ -475,7 +475,7 @@ func TestGetwd(t *testing.T) {
}
oldwd := os.Getenv("PWD")
for _, d := range dirs {
// Check whether d exists, is a dir and whether it contains a symlink
// Check whether d exists, is a dir and that d's path does not contain a symlink
fi, err := os.Stat(d)
if err != nil || !fi.IsDir() {
t.Logf("Test dir %s stat error (%v) or not a directory, skipping", d, err)
@@ -483,7 +483,7 @@ func TestGetwd(t *testing.T) {
}
check, err := filepath.EvalSymlinks(d)
if err != nil || check != d {
t.Logf("Test dir %s (%s), is symlink or other error (%v), skipping", d, check, err)
t.Logf("Test dir %s (%s) is symlink or other error (%v), skipping", d, check, err)
continue
}
err = os.Chdir(d)