gsrlabs/term
1
0
Fork 0
mirror of https://github.com/golang/term.git synced 2026-01-29 07:02:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

Clarify limitation/corner case of CRLF in test

Browse Source
This commit is contained in:
Laurent Demailly
2025-07-16 11:00:25 -07:00
parent cb5628d50c
commit 0cf26df9ae
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
terminal_test.go
View File

@@ -313,7 +313,11 @@ func TestRender(t *testing.T) {
func TestCRLF(t *testing.T) {
c := &MockTerminal{
toSend: []byte("line1\rline2\r\nline3\n"),
// bytesPerRead 0 means read all at once - CR+LF need to be in same read which is what terminals would do.
// bytesPerRead 0 in this test means read all at once
// CR+LF need to be in same read for ReadLine to not produce an extra empty line
// which is what terminals do for reasonably small paste. if way many lines are pasted
// and going over say 1k-16k buffer, readline current implementation will possibly generate 1
// extra empty line, if the CR is in chunk1 and LF in chunk2 (and that's fine).
}
ss := NewTerminal(c, "> ")