term_test.go: replace io/ioutil with io and os package

For golang/go#45557 Change-Id: I27cfebf64dd4597e3f00ea3fbb32d670619b5c45 GitHub-Last-Rev: 4c4433c530 GitHub-Pull-Request: golang/term#9 Reviewed-on: https://go-review.googlesource.com/c/term/+/430798 Run-TryBot: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>
A+C: delete AUTHORS and CONTRIBUTORS
2026-02-09 04:06:04 +03:00 · 2022-09-19 17:04:32 +00:00 · 2022-07-22 15:52:59 +00:00 · 2022-05-26 00:47:31 +00:00 · 2022-04-11 21:56:00 +00:00 · 2021-09-27 22:27:41 +00:00
9 changed files with 14 additions and 18 deletions
--- a/3
+++ b/3
@@ -1,3 +0,0 @@
-# This source code refers to The Go Authors for copyright purposes.
-# The master list of authors is in the main Go distribution,
-# visible at http://tip.golang.org/AUTHORS.
--- a/3
+++ b/3
@@ -1,3 +0,0 @@
-# This source code was written by the Go contributors.
-# The master list of contributors is in the main Go distribution,
-# visible at http://tip.golang.org/CONTRIBUTORS.
--- a/codereview.cfg
+++ b/codereview.cfg
@@ -0,0 +1 @@
+issuerepo: golang/go
--- a/go.mod
+++ b/go.mod
@@ -2,4 +2,4 @@ module golang.org/x/term

 go 1.17

-require golang.org/x/sys v0.0.0-20201119102817-f84b799fce68
+require golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1
--- a/go.sum
+++ b/go.sum
@@ -1,2 +1,2 @@
-golang.org/x/sys v0.0.0-20201119102817-f84b799fce68 h1:nxC68pudNYkKU6jWhgrqdreuFiOQWj1Fs7T3VrH4Pjw=
-golang.org/x/sys v0.0.0-20201119102817-f84b799fce68/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1 h1:SrN+KX8Art/Sf4HNj6Zcz06G7VEz+7w9tdXTPOZ7+l4=
+golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
--- a/term.go
+++ b/term.go
@@ -7,11 +7,13 @@
 //
 // Putting a terminal into raw mode is the most common requirement:
 //
-// 	oldState, err := term.MakeRaw(int(os.Stdin.Fd()))
-// 	if err != nil {
-// 	        panic(err)
-// 	}
-// 	defer term.Restore(int(os.Stdin.Fd()), oldState)
+//	oldState, err := term.MakeRaw(int(os.Stdin.Fd()))
+//	if err != nil {
+//	        panic(err)
+//	}
+//	defer term.Restore(int(os.Stdin.Fd()), oldState)
+//
+// Note that on non-Unix systems os.Stdin.Fd() may not be 0.
 package term

 // State contains the state of a terminal.
--- a/term_test.go
+++ b/term_test.go
@@ -5,7 +5,6 @@
 package term_test

 import (
-	"io/ioutil"
 	"os"
 	"runtime"
 	"testing"
@@ -14,7 +13,7 @@ import (
 )

 func TestIsTerminalTempFile(t *testing.T) {
-	file, err := ioutil.TempFile("", "TestIsTerminalTempFile")
+	file, err := os.CreateTemp("", "TestIsTerminalTempFile")
 	if err != nil {
 		t.Fatal(err)
 	}
--- a/terminal.go
+++ b/terminal.go
@@ -935,7 +935,7 @@ func (s *stRingBuffer) Add(a string) {
 // next most recent, and so on. If such an element doesn't exist then ok is
 // false.
 func (s *stRingBuffer) NthPreviousEntry(n int) (value string, ok bool) {
-	if n >= s.size {
+	if n < 0 || n >= s.size {
 		return "", false
 	}
 	index := s.head - n
--- a/terminal_test.go
+++ b/terminal_test.go
@@ -407,7 +407,7 @@ func TestMakeRawState(t *testing.T) {
 		t.Fatalf("failed to get terminal state from GetState: %s", err)
 	}

-	if runtime.GOOS == "ios" || (runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64")) {
+	if runtime.GOOS == "ios" {
 		t.Skip("MakeRaw not allowed on iOS; skipping test")
 	}
Author	SHA1	Message	Date
cui fliter	7a66f970e0	term_test.go: replace io/ioutil with io and os package For golang/go#45557 Change-Id: I27cfebf64dd4597e3f00ea3fbb32d670619b5c45 GitHub-Last-Rev: `4c4433c530` GitHub-Pull-Request: golang/term#9 Reviewed-on: https://go-review.googlesource.com/c/term/+/430798 Run-TryBot: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>	2022-09-19 17:04:32 +00:00
Russ Cox	a9ba230a40	A+C: delete AUTHORS and CONTRIBUTORS In 2009, Google's open-source lawyers asked us to create the AUTHORS file to define "The Go Authors", and the CONTRIBUTORS file was in keeping with open source best practices of the time. Re-reviewing our repos now in 2022, the open-source lawyers are comfortable with source control history taking the place of the AUTHORS file, and most open source projects no longer maintain CONTRIBUTORS files. To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos. For golang/go#53961. Change-Id: I049817224d2238c682ba92fbfba1d265bea183c8 Reviewed-on: https://go-review.googlesource.com/c/term/+/419104 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: David Chase <drchase@google.com>	2022-07-22 15:52:59 +00:00
ardnew	065cf7ba24	x/term: prevent invalid indexing into stRingBuffer The exported method (*stRingBuffer).NthPreviousEntry does not correctly handle arguments with negative values. A negative value will index beyond slice boundaries in most cases (unless size = max = INT_MAX) and cause an access violation at runtime. This change adds a condition to return ok = false for all negatively valued arguments, which is the same behavior that occurs with positively valued arguments exceeding buffer length. Adding the capability to index backwards (from the end of the slice) does not seem like the intent of this method, and it would not improve or simplify existing functionality. It would also be inconsistent with the handling of positive values out-of-bounds. Change-Id: Ib4113330f0044dd5b73c7d75c5cdcdd27d60ee77 GitHub-Last-Rev: `fec355f536` GitHub-Pull-Request: golang/term#8 Reviewed-on: https://go-review.googlesource.com/c/term/+/408754 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>	2022-05-26 00:47:31 +00:00
Russ Cox	e5f449aeb1	all: gofmt Gofmt to update doc comments to the new formatting. For golang/go#51082. Change-Id: Ib37025f3feda6c1ac63a48247a644dd5afac2be8 Reviewed-on: https://go-review.googlesource.com/c/term/+/399619 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>	2022-04-11 21:56:00 +00:00
Tobias Klauser	03fcf44c22	term: add codereview.cfg This will let git codereview rewrite issue references to the golang/go repo. See https://golang.org/cl/4131 for details. Change-Id: I5d5871b8570cdd448949a5a984027f909ab521a5 Reviewed-on: https://go-review.googlesource.com/c/term/+/352590 Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org>	2021-09-27 22:27:41 +00:00
Tobias Klauser	f766a8b9ae	term: enable TestMakeRawState on darwin/arm64 Go 1.16 renamed the iOS port from darwin/arm64 to ios/arm64 and darwin/arm64 was repurposed for the macOS ARM64 port (see https://golang.org/doc/go1.16#darwin). Now that Go 1.16 is the oldest supported release, the ios tag can be used exclusively to detect iOS and TestMakeRawState which ought to run on darwin/arm64 can be enabled on that platform. For golang/go#45696 Change-Id: Ic51903ea94def1f1144ca74db37533b5c4de8522 Reviewed-on: https://go-review.googlesource.com/c/term/+/352589 Trust: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Ian Lance Taylor <iant@golang.org>	2021-09-27 21:18:40 +00:00
Alan Donovan	140adaaadf	term: add portability note re: std{in,out} fds I recently made the mistake of assuming that stdin and stdout's fds were 0 and 1, respectively, leading to a bug report from a Windows user. With luck this note should prevent others from making the same mistake. Change-Id: I5391d91c431c3a801617f50d1b6a61121e2a939f Reviewed-on: https://go-review.googlesource.com/c/term/+/349149 Reviewed-by: Ian Lance Taylor <iant@golang.org> Trust: Carlos Amedee <carlos@golang.org>	2021-09-16 21:49:54 +00:00
Bryan C. Mills	6886f2dfbf	all: upgrade x/sys to latest This fixes a build error observed in https://build.golang.org/log/13b332a441d4d18d5358f87f945cafba3d7b9d4e. Change-Id: I7ea6ba6e6bbeb30dabc28952306b28997410d07a Reviewed-on: https://go-review.googlesource.com/c/term/+/328150 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Go Bot <gobot@golang.org>	2021-06-15 17:13:37 +00:00