term_test.go: replace io/ioutil with io and os package

For golang/go#45557 Change-Id: I27cfebf64dd4597e3f00ea3fbb32d670619b5c45 GitHub-Last-Rev: 4c4433c530 GitHub-Pull-Request: golang/term#9 Reviewed-on: https://go-review.googlesource.com/c/term/+/430798 Run-TryBot: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>
A+C: delete AUTHORS and CONTRIBUTORS
2026-02-09 04:06:04 +03:00 · 2022-09-19 17:04:32 +00:00 · 2022-07-22 15:52:59 +00:00 · 2022-05-26 00:47:31 +00:00 · 2022-04-11 21:56:00 +00:00
5 changed files with 7 additions and 14 deletions
--- a/3
+++ b/3
@@ -1,3 +0,0 @@
-# This source code refers to The Go Authors for copyright purposes.
-# The master list of authors is in the main Go distribution,
-# visible at http://tip.golang.org/AUTHORS.
--- a/3
+++ b/3
@@ -1,3 +0,0 @@
-# This source code was written by the Go contributors.
-# The master list of contributors is in the main Go distribution,
-# visible at http://tip.golang.org/CONTRIBUTORS.
--- a/term.go
+++ b/term.go
@@ -7,11 +7,11 @@
 //
 // Putting a terminal into raw mode is the most common requirement:
 //
-// 	oldState, err := term.MakeRaw(int(os.Stdin.Fd()))
-// 	if err != nil {
-// 	        panic(err)
-// 	}
-// 	defer term.Restore(int(os.Stdin.Fd()), oldState)
+//	oldState, err := term.MakeRaw(int(os.Stdin.Fd()))
+//	if err != nil {
+//	        panic(err)
+//	}
+//	defer term.Restore(int(os.Stdin.Fd()), oldState)
 //
 // Note that on non-Unix systems os.Stdin.Fd() may not be 0.
 package term
--- a/term_test.go
+++ b/term_test.go
@@ -5,7 +5,6 @@
 package term_test

 import (
-	"io/ioutil"
 	"os"
 	"runtime"
 	"testing"
@@ -14,7 +13,7 @@ import (
 )

 func TestIsTerminalTempFile(t *testing.T) {
-	file, err := ioutil.TempFile("", "TestIsTerminalTempFile")
+	file, err := os.CreateTemp("", "TestIsTerminalTempFile")
 	if err != nil {
 		t.Fatal(err)
 	}
--- a/terminal.go
+++ b/terminal.go
@@ -935,7 +935,7 @@ func (s *stRingBuffer) Add(a string) {
 // next most recent, and so on. If such an element doesn't exist then ok is
 // false.
 func (s *stRingBuffer) NthPreviousEntry(n int) (value string, ok bool) {
-	if n >= s.size {
+	if n < 0 || n >= s.size {
 		return "", false
 	}
 	index := s.head - n
Author	SHA1	Message	Date
cui fliter	7a66f970e0	term_test.go: replace io/ioutil with io and os package For golang/go#45557 Change-Id: I27cfebf64dd4597e3f00ea3fbb32d670619b5c45 GitHub-Last-Rev: `4c4433c530` GitHub-Pull-Request: golang/term#9 Reviewed-on: https://go-review.googlesource.com/c/term/+/430798 Run-TryBot: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>	2022-09-19 17:04:32 +00:00
Russ Cox	a9ba230a40	A+C: delete AUTHORS and CONTRIBUTORS In 2009, Google's open-source lawyers asked us to create the AUTHORS file to define "The Go Authors", and the CONTRIBUTORS file was in keeping with open source best practices of the time. Re-reviewing our repos now in 2022, the open-source lawyers are comfortable with source control history taking the place of the AUTHORS file, and most open source projects no longer maintain CONTRIBUTORS files. To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos. For golang/go#53961. Change-Id: I049817224d2238c682ba92fbfba1d265bea183c8 Reviewed-on: https://go-review.googlesource.com/c/term/+/419104 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: David Chase <drchase@google.com>	2022-07-22 15:52:59 +00:00
ardnew	065cf7ba24	x/term: prevent invalid indexing into stRingBuffer The exported method (*stRingBuffer).NthPreviousEntry does not correctly handle arguments with negative values. A negative value will index beyond slice boundaries in most cases (unless size = max = INT_MAX) and cause an access violation at runtime. This change adds a condition to return ok = false for all negatively valued arguments, which is the same behavior that occurs with positively valued arguments exceeding buffer length. Adding the capability to index backwards (from the end of the slice) does not seem like the intent of this method, and it would not improve or simplify existing functionality. It would also be inconsistent with the handling of positive values out-of-bounds. Change-Id: Ib4113330f0044dd5b73c7d75c5cdcdd27d60ee77 GitHub-Last-Rev: `fec355f536` GitHub-Pull-Request: golang/term#8 Reviewed-on: https://go-review.googlesource.com/c/term/+/408754 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>	2022-05-26 00:47:31 +00:00
Russ Cox	e5f449aeb1	all: gofmt Gofmt to update doc comments to the new formatting. For golang/go#51082. Change-Id: Ib37025f3feda6c1ac63a48247a644dd5afac2be8 Reviewed-on: https://go-review.googlesource.com/c/term/+/399619 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@google.com>	2022-04-11 21:56:00 +00:00