Alex Brainman 1a268e5305 ssh/terminal: adjust ReadConsole rules on windows ...

CL 212377 changed end of input character on windows - from \n to \r.
But CL 212377 did not adjust ReadConsole accordingly. For example,
after CL 212377 \n was still used to end of password processing,
and \r was ignored.

This CL swaps these rules - \r is now used to end password processing,
and \n are ignored. The change only affects windows, all non windows
code should work as before.

This CL also adjusts TestReadPasswordLineEnd to fit new rules.

Fixes golang/go#36609

Change-Id: I027bf80d10e7d4d4b17ff0264935d14b8bea9097
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/215417
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>

2020-02-08 06:05:01 +00:00

terminal_test.go

ssh/terminal: adjust ReadConsole rules on windows

2020-02-08 06:05:01 +00:00

terminal.go

ssh/terminal: adjust ReadConsole rules on windows

2020-02-08 06:05:01 +00:00

util_aix.go

ssh/terminal: add AIX operating system

2018-11-26 09:39:34 +00:00

util_bsd.go

ssh/terminal: use termios ioctl read/write constants from x/sys/unix

2017-07-28 18:30:02 +00:00

util_linux.go

ssh/terminal: use termios ioctl read/write constants from x/sys/unix

2017-07-28 18:30:02 +00:00

util_plan9.go

ssh/terminal: use "reports whether" in IsTerminal doc

2018-11-26 16:34:21 +00:00

util_solaris.go

ssh/terminal: use "reports whether" in IsTerminal doc

2018-11-26 16:34:21 +00:00

util_windows.go

ssh/terminal: stop using ENABLE_LINE_INPUT

2020-01-15 08:54:10 +00:00

util.go

ssh/terminal: use "reports whether" in IsTerminal doc

2018-11-26 16:34:21 +00:00

Description

No description provided

BSD-3-Clause 248 KiB

Languages

Go 100%